Skip to content

馃悰 Fix Sonner toast theme sync - #2450

Merged
alejsdev merged 1 commit into
fastapi:masterfrom
christosuster:fix/sonner-theme
Aug 21, 2026
Merged

馃悰 Fix Sonner toast theme sync#2450
alejsdev merged 1 commit into
fastapi:masterfrom
christosuster:fix/sonner-theme

Conversation

@chris-bs23

@chris-bs23 chris-bs23 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sonner imported `useTheme` from `next-themes`, but the app only wraps the custom `ThemeProvider`, so toast theme always fell back to OS `system`.
  • Wire Sonner to `@/components/theme-provider` and remove unused `next-themes`.

Test plan

  • Light / Dark / System appearance
  • Success and error toasts match app theme when OS preference differs

@alejsdev alejsdev changed the title Fix Sonner toast theme sync 馃悰 Fix Sonner toast theme sync Aug 21, 2026
@alejsdev

Copy link
Copy Markdown
Member

Good catch, thank you! @chris-bs23 馃帀

@alejsdev alejsdev added the bug Something isn't working label Aug 21, 2026
@alejsdev
alejsdev merged commit f369a27 into fastapi:master Aug 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants